project-codeflare / project-codeflare/codeflare-sdk

Create local_client_url() cluster method to return the local client url

Open
#173 0 comments 0 reactions 1 assignee View on GitHub

@tedhtchang is already working on this.

Since Jun 29, 2023.

Dominant language
Python
Stars
35
Forks
66
Avg merge
48m
Merged PRs (30d)
7

Description

The PR tracks the following issues:

  1. Get rid of the following code in the notebook in this PR:
    The conversation.
with oc.project(cluster.config.namespace):
    routes=oc.selector("route").objects()
    rayclient_url=""
    for r in routes:
        if "rayclient" in r.name():
            rayclient_url=r.model.spec.host
ray.init(address=f"ray://{rayclient_url}", logging_level="DEBUG")

and create a local_client_url() method so we only need to do:

ray.init(address=cluster.local_client_url(), logging_level="DEBUG")

(Edited)

  1. Also remove the oc.whoami with the k8s client implementation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.