project-codeflare / project-codeflare/appwrapper

Support a single target resource for doneness/deletion trigger

Open
#383 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
19
Forks
15
Avg merge
1d 12h
Merged PRs (30d)
7

Description

Single deletion target

In the llm-d project we have an interesting problem where we need to deploy pretty often:

  1. 2 Deployments or LWS (using Kueue for this solves a lot of resource coordination problems with experiments)
  2. A Job containing a simulated inference workload (like guidellm) or unit tests
  3. A whole bunch of other configuration resources that can also be ephemeral but aren't scheduleable

It's my understanding that the AppWrapper never exits because the Deployments are never considered to be done.

It would be a great feature to allow defining a single target resource that is used to garbage collect everything else in the AppWrapper, then I wouldn't have to include a poison pill or self-destruct script that triggers after the benchmark is complete to tear down the inference deployment. I would set the target deletion resource to be the Job.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the AppWrapper controller's doneness and deletion handling, focusing on how Deployments, LWS resources, and Jobs are evaluated. Trace how an AppWrapper currently reaches completion and how its resources are garbage-collected. Done means a configured Job or other single target can trigger cleanup of the remaining AppWrapper resources without a poison pill or self-destruct script.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.