project-codeflare / project-codeflare/appwrapper

Cross-check wrapped GVKs against the AppWrapper operator's RBACs

Open
#112 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
19
Forks
15
Avg merge
1d 12h
Merged PRs (30d)
7

Description

In the admission webhook, we should check that the AppWrapper controller itself has the permission to create the resources that are wrapped before we admit it (in addition to validating that the user has the permissions too).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the admission webhook and trace the existing validation of wrapped GVKs and the user's permissions. Then inspect how the AppWrapper controller's RBAC permissions are represented. Done means admission also checks that the controller can create every wrapped resource, while retaining the user-permission check.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authorization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.