project-chip / project-chip/matter-test-scripts
[drlk_2_x_common.py] The script does not check for support of either Max or Min pin code length and tries to generate a incorrect pin code and fails.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 19
- Forks
- 7
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 3
Description
Summary Title:
Description:
Support for Max pin code length and Min pin code length attributes is not mandatory. At lines 231-236 the script tries to create an incorrect PIN using these 2 attributes. There are no PICS checks in place to prevent this code from running. Any device that does not support both attributes will fail this step. [drlk_2_x_common.py] is used by TC-DRLK-2.2, TC-DRLK-2.3 and TC-DRLK-2.12.
Steps to reproduce:
TC-DRLK-2.2, TC-DRLK-2.3 and TC-DRLK-2.12 are not operable with any device that does not support both Max pin code length and Min pin code length attributes.
Additional Info:
Bug prevalence
Always
GitHub hash of the SDK that was being used
Main
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect drlk_2_x_common.py at lines 231-236 and review the PICS checks used by TC-DRLK-2.2, TC-DRLK-2.3, and TC-DRLK-2.12. The work is complete when devices without both Max pin code length and Min pin code length support no longer attempt the invalid PIN generation step, while supported devices continue to run it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100