project-chip / project-chip/matter-test-scripts

[TC-OPCREDS-3.2] - steps_TC_OPCREDS_3_2 method does NOT follow expected TH parser template

Open
#268 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v1.4
Dominant language
Python
Stars
19
Forks
7
Avg merge
3d 17h
Merged PRs (30d)
3

Description

Description:

The steps_TC_OPCREDS_3_2 method is not following the current TH parser template since the description argument for TestStep are using formatted string and methods, instead it should only use plain text for method descriptions.

For example :

 TestStep(1, f"{commission_from_existing('CR1', 'CR2')}\n. Save the FabricIndex from the NOCResponse as `fabric_index_CR2`.",
                         verify_commissioning_successful())

This step above should be written in a way to avoid formatted string and method, so it might be re-written to:

 TestStep(1, "Commission from existing CR1 or CR2\n. Save the FabricIndex from the NOCResponse as `fabric_index_CR2`.",
"Verify the commissioning is successful.")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the steps_TC_OPCREDS_3_2 method and review each TestStep description against the current TH parser template. Replace formatted strings and method calls in descriptions with plain text, then confirm all descriptions in the method follow the shown pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.