profcomff / profcomff/rating-api
Переписать реализацию ручки GET lecturer
Nobody has claimed this yet.
- #53 by @Spangi2000 — closed without merging
- Dominant language
- Python
- Stars
- 8
- Forks
- 3
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 2
Description
Сейчас не очень хорошая реализация, так как много циклов for по всевозможным комментариям.
Надо переписать реализацию, оставив только один цикл по всем комментариям, а все проверки делать на каждой итерации, затем добавлять свалидированную модельку в result
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the GET lecturer handler and inspect how it currently processes comments across its multiple loops. Trace the validation and filtering conditions, then consolidate them into one pass that appends validated models to the result. Confirm that the endpoint still returns the expected lecturer data using the repository's existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100