processone / processone/ejabberd
mod_pubsub force_node_config doesn't override details in the database
Nobody has claimed this yet.
- Dominant language
- Erlang
- Stars
- 6.7k
- Forks
- 1.6k
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
When we change something such as
mod_pubsub:
force_node_config:
"urn:xmpp:avatar:*":
access_model: open
it only applies to newly created items rather than all items that exist
Describe the solution you'd like
I believe the node_config() merge of data + forced config should happen at retrieval time as well as in create_node.
Describe alternatives you've considered
At the very least this non-modification of existing records should be documented behaviour.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin by tracing mod_pubsub's node_config() merge and create_node paths, then inspect how existing node details are retrieved from the database. Done means the behavior for forced configuration on existing records is implemented consistently at retrieval time, or the non-modification behavior is documented if that approach is rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- erlang
- Domain
- backend, databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100