processone / processone/ejabberd

Concerns in mod_mam default values

Open
#3,630 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Component:MAM Kind:Documentation
Dominant language
Erlang
Stars
6.7k
Forks
1.6k
PR merge metrics
No merged PRs in 30d

Description

Erik Grun reported several problems by email. I reproduce here the unresolved ones:


It says on the page "Modules Options" under the "mod_mam" section:

assume_mam_usage: true | false
[…] The default value is false.

but in the default configuration (which gets installed with the RPM package) it is set to "true".


I am wondering, why the default value in "mod_mam" for "default" is set to "never".

It is confusing, because I still get the points in Daniel Gulschs "Compliance Tester", but it disables the expected behaviour from the module. (I have the same issue with In-Band Registration. Although this should probably be handled differently.)

This default setting does also seem to break "mod_carboncopy".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the mod_mam options on the documented Modules Options page with the default configuration installed by the RPM package. Check the effects of the default setting on mod_mam, In-Band Registration, and mod_carboncopy; done means resolving the discrepancies and documenting or correcting the intended defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
erlang
Domain
backend, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.