Add request time to generated by mod_http_upload external_secret

Open
#3,189 0 comments 1 reaction 1 assignee View on GitHub

@weiss is already working on this.

Since Mar 24, 2020.

Assessment

This issue has not been assessed yet.

Description

Kind:Feature

Is your feature request related to a problem? Please describe.
I want to use mod_http_upload option external_secret with an self-written php script. https://xmpp.org/extensions/xep-0363.html#impl suggests to implement a timeout for the validity of the PUT URL. For this, the server (php script) has to know the time of the XMPP request for the upload slots.

Describe the solution you'd like
I suggest to extend the currently used URL format to include the unix timestamp in the PUT URL path:
<configured_put_url>/<SHA-1(JID)>/<random>/<timestamp>/<filename>
As far as I understood the Prosody decumentation ( https://modules.prosody.im/mod_http_upload_external.html ), the path format isn't specified. So the addition of another field shouldn't break compatibility (at least if no script expects the filename at a certain index but as the last path element, see #3188)

Dominant language
Erlang
Stars
6.7k
Forks
1.6k
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from processone/ejabberd

All issues in processone/ejabberd

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.