processing / processing/p5.js

Use Cubemaps for Light Feature Performance Improvement

Open
#6,587 6 comments 0 reactions 1 assignee View on GitHub

@Garima3110 is already working on this.

Since Nov 24, 2023.

Area:Accessibility Area:WebGL Enhancement
Dominant language
JavaScript
Stars
24k
Forks
3.8k
Avg merge
3d 16h
Merged PRs (30d)
25

Description

Increasing Access

This is with reference to issue #6531 .

The current implementation of the light feature in p5.js utilizes equirectangular textures, which may involve trigonometric calculations for texture coordinates, potentially impacting performance. This issue proposes exploring the use of cubemaps as an alternative approach to enhance performance.

Most appropriate sub-area of p5.js?
  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)
Feature enhancement details
  1. Assessing the visual quality of the light feature when using cubemaps compared to equirectangular textures to ensure that the proposed change does not compromise the intended visual effects.
  2. Verifying the compatibility of cubemaps across different browsers to ensure a consistent and reliable user experience.
  3. Testing the feature using cubemaps on various devices and screen resolutions to ensure compatibility and performance improvements.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.