processing / processing/p5.js

Test failing in current build

Open
#5,788 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Build Process
Dominant language
JavaScript
Stars
24k
Forks
3.8k
Avg merge
3d 16h
Merged PRs (30d)
25

Description

Most appropriate sub-area of p5.js?
  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)
p5.js version

1.4.2

Web browser and version

NA

Operating System

OS X 11.6.2

Steps to reproduce this

Follow the instructions here: https://p5js.org/contributor-docs/#/?id=development-process and note failing tests in console and browser:

867 passing (60s)
1 failing

  1. src/io/files.js
    loadJSON documentation
    example #1 works:
    Error: Timeout of 4000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Warning: [object Object] Use --force to continue.

Aborted due to warnings.
npm ERR! code ELIFECYCLE
npm ERR! errno 3
npm ERR! p5@1.4.2 grunt: grunt
npm ERR! Exit status 3
npm ERR!
npm ERR! Failed at the p5@1.4.2 grunt script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

AND (in the browser)

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Follow the development process instructions and reproduce the failure with the project’s grunt test command. Start in src/io/files.js at the loadJSON documentation example #1, then compare the console timeout with the browser failure. Done means the failing example completes and the test suite passes in both reported environments.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.