processing / processing/p5.js

GIFs that don't loop break unless reset before play()

Open
#5,228 11 comments 0 reactions 1 assignee View on GitHub

@davepagurek is already working on this.

Since Jun 18, 2024.

Area:Image Bug Help Wanted p5.js 2.0+
Dominant language
JavaScript
Stars
24k
Forks
3.8k
Avg merge
3d 16h
Merged PRs (30d)
25

Description

Most appropriate sub-area of p5.js?
  • Accessibility (Web Accessibility)
  • Build tools and processes
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Friendly error system
  • Image
  • IO (Input/Output)
  • Localization
  • Math
  • Unit Testing
  • Typography
  • Utilities
  • WebGL
  • Other (specify if possible)
Details about the bug:
  • p5.js version: 1.0+
  • Web browser and version: all
  • Operating System: all
  • Steps to reproduce this:
    Here is an example. Comment out the gif.setFrame(0) to see the crash and unfriendly error log.

I think it is okay to expect the coder to manually reset to the beginning of a non-looping GIF before playing but when they don't do that it shouldn't crash. A check to make sure that gifProperties.displayIndex never exceeds gifProperties.frames.length - 1 should do the trick!

This could be a nice issue for a newer contributor. I am happy to help.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.