processing / processing/p5.js-website

Fix explanation about curvePoints

Open
#701 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
MDX
Stars
96
Forks
322
Avg merge
5d 22h
Merged PRs (30d)
8

Description

Increasing Access

Unsure

Most appropriate sub-area of p5.js?

Reference

Feature request details
Change Parameter explination under curvePoint() from:

Parameters

a Number: coordinate of first anchor point.
b Number: coordinate of first control point.
c Number: coordinate of second control point.
d Number: coordinate of second anchor point.
t Number: amount to interpolate between 0 and 1.

To Newer version:

Parameters

a Number: coordinate of first control point.
b Number: coordinate of first anchor point.
c Number: coordinate of second anchor point.
d Number: coordinate of second control point.
t Number: amount to interpolate between 0 and 1.

Reasoning

Under curve() they use:

curve(x1, y1, x2, y2, x3, y3, x4, y4)
-- x1 ------ y1------ x2 --- y2 ----- x3 ----- y3 ----- x4 ----- y4
control, control, anchor anchor, anchor, anchor, control, control

curvePoint() uses:
(If adding a curvePoint() under the X coords)

curvePoint(x1, x2, x3, x4)
control, anchor, anchor, control

But in the explanation, they say it uses:

curvePoint(x2, x3, x1, x4)
anchor, control, control, anchor

This confused me at first since I am new to programming in JavaScript and would like to help others to try not to confuse them

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the curvePoint() reference page linked in the issue and compare its parameter descriptions with the curve() documentation. Update the curvePoint() parameter explanations to match the stated control-point and anchor-point order, then verify that the published wording is consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.