processing / processing/p5.js-web-editor
Remove Edit Ability for Non-owned sketches
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 1.7k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 8
Description
Nature of issue?
-
Existing feature enhancement
-
Web browser and version: FF 65.0.1 (64-bit)
-
Operating System: OSX 10.13.4
-
Steps to reproduce this bug: Open a sketch that is not owned by your account and attempt to add a file in the sketch menu
Feature enhancement details:
When looking at a sketch that is not your own (under you logged in account) you cannot add a file / folder. This is expected behavior, but I feel that there should be some feedback there to let you know that you're attempting to work on a sketch that is not your own. Especially because you can edit the code and have it run even if it's not technically 'your' sketch yet.
Either blocking out those menu items or giving a dialogue that they need to duplicate the sketch first might be options?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sketch menu described in the reproduction steps and compare its behavior for owned and non-owned sketches. Verify the current editing and file-addition behavior while logged in, then determine which feedback or access restriction the project accepts. Done means non-owned sketches no longer present misleading editing controls, or clearly direct the user to duplicate the sketch first.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100