processing / processing/p5.js-web-editor

Can't upload files from a cloned p5.js repo

Open
#657 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Priority:Medium
Dominant language
JavaScript
Stars
1.7k
Forks
1.7k
Avg merge
3d 4h
Merged PRs (30d)
8

Description

Hey so I found another weird one. I can't browse or upload files from the p5.js repo if it's been installed via git clone. If I just download by zip, I can browse no problem. I can also browse other (non p5.js) git repo's that I've cloned without issue.

When you click open on p5.js, the uploader tells you that it can't download a null file.
screen shot 2018-06-25 at 8 27 09 pm

The little tick mark arrow next to the folder also doesn't appear.
screen shot 2018-06-25 at 8 28 11 pm
I'm guessing there's other folders that this would happen with as well but I couldn't seem to find any on my machine. I was able to copy files outside of the p5.js repo folder and upload them individually.

I found this bug when I was trying to upload a newer build of p5.js that I made today after updating a dev dependency. I also tried this on another machine (also osx 10.13.3) and the bug persisted.

Also not clear to me is if this is an issue with the editor or something to do with the p5.js repo itself. I checked permissions on the repo and they looked fine (Everyone can read / write). I tried to browse files using other websites and had no issue.

I also tried removing the . from the folder name to see if that was the issue, as well as just renaming it to something entirely different but neither of those worked.

Nature of issue?
  • Found a bug
  • Existing feature enhancement
  • New feature request
Details about the bug:
  • Web browser and version: Chrome 67, Firefox 60.0.2
  • Operating System: OSX 10.13.3
  • Steps to reproduce this: Try to browse files from a cloned p5.js repo

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Chrome or Firefox on macOS with a cloned p5.js repository, then compare it with a ZIP download and another cloned repository. Trace the uploader behavior when it reports a null file and when the folder arrow is missing; done means browsing and uploading files from the cloned p5.js repository works reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.