processing / processing/p5.js-web-editor

when including files in `<head>` in `index.html`, path prefix is incorrect

Open
#482 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Priority:Medium
Dominant language
JavaScript
Stars
1.7k
Forks
1.7k
Avg merge
3d 4h
Merged PRs (30d)
8

Description

Nature of issue?
  • Found a bug
  • Existing feature enhancement
  • New feature request
Details about the bug:
  • Web browser and version: Chrome 62.0.3202.94
  • Operating System: Mac OS X
  • Steps to reproduce this:

see the following example sketch: http://alpha.editor.p5js.org/cassie/sketches/Sk1Amg9eG

if you try to include an asset in the <head>, it makes a request to /:username/sketches/:path_to_asset rather than /:username/sketches/:sketch_id/:path_to_asset.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with index.html and reproduce the issue using the linked example sketch in Chrome. Inspect the request generated when an asset is included in the ; done means the request includes the sketch ID between the username and the asset path, rather than omitting it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.