processing / processing/p5.js-web-editor
Infinite loop protection is switched off when changing library version
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 1.7k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 8
Description
p5.js version
2.3.2
What is your operating system?
Mac OS
Web browser and version
Firefox 155.0.1
Actual Behavior
If you have the infinite loop protection 'on' and then change the library version it switches off the loop protection and the user has to remember to manually reinstate it. The <!-- noprotect --> line is removed from the html file.
Expected Behavior
I would expect the infinite loop protection on setting to be fixed and that it should only be changed by the user in the configuration settings.
Steps to reproduce
Steps:
- Create a sketch
- Set infinite loop protection on in the configuration settings
- Return to the editor pane
- Change the library version in the configuration settings
If you go back to the configuration settings or look in the HTML file this feature has been switched off.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by enabling infinite loop protection, returning to the editor, and changing the library version. Inspect the configuration change flow and the generated HTML around the line; done means changing the library version preserves the user's protection setting and marker.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100