processing / processing/p5.js-web-editor

Make e2e tests mandatory for PR merging

Open
#4,284 0 comments 0 reactions 1 assignee View on GitHub

@clairep94 is already working on this.

Since Sep 1, 2026.

Awaiting Maintainer Approval Enhancement
Dominant language
JavaScript
Stars
1.7k
Forks
1.7k
Avg merge
3d 4h
Merged PRs (30d)
8

Description

Increasing Access

Unsure

Feature enhancement details

Context:

This issue is a followup from GSOC:

  • @Geethegreat has create an e2e test suite for his GSOC 2026 project
  • We purposely made it so that e2e tests were not required for merging PR's so that the GSOC project did not unnecessarily block other work on the repo
  • We also purposely made it so that e2e tests were gated by approval from @Geethegreat, @clairep94, @khanniie, or @raclim during the GSOC period, so that we did not accidentally overspend on GHA hours

  • Now that GSOC is complete, we should update so that the e2e test suite is mandatory for merging into develop
  • Ideally we should update to:
    • Remove the approval gating
    • Have e2e tests trigger automatically after successful unit tests
    • Add some concurrency rules to ensure this doesn't result in a lot of GHA hours useage
      • Cancel any in-progress runs if a later run is triggered
      • Maybe debounce triggers if this is possible
    • Ideally update to minimize the required amount of time for e2e tests to run:
      • Make app startup in CI faster if possible
      • Caching any installations (some work previously done here already)

--> Will self-assign this issue

Requirements:

  • Access to repo settings > environments & branch protection

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.