processing / processing/p5.js-web-editor
Keyboard shortcuts modal is out of sync with actual keybindings
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 1.7k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 8
Description
Follow-up to #4222 (see this comment for context) — KeyboardShortcutModal.jsx has drifted from what's actually wired up in keymaps.js. A few known discrepancies:
Advertised but not implemented:
- The modal lists
{Ctrl/Cmd}+Hfor "Replace," but there's noreplacecommand wired up anywhere inkeymaps.js. Worth deciding: implement it (CodeMirror 6's search panel already supports replace, just needs to be exposed on this shortcut), or remove the claim from the modal if it's not planned.
Implemented but not advertised:
Ctrl-Shift-Up/Down(Cmd-Ctrl-Up/Downon Mac) — move line up/down, added in #4250.Shift-Ctrl-D(Shift-Cmd-Don Mac) — duplicate line, andCtrl-Up/Down(Ctrl-Alt-Up/Downon Mac) — scroll without moving cursor, both pending in a follow-up PR.
Proposal
- Decide the fate of the Replace shortcut (implement vs. remove from modal).
- Add entries to
KeyboardShortcutModal.jsxfor the shortcuts above.
Happy to take this on.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing KeyboardShortcutModal.jsx with keymaps.js, then review the context in #4222 and the implementation from #4250. Resolve whether the Replace shortcut should be implemented or removed, and document the listed implemented or pending shortcuts in the modal. Done means the modal matches the keybindings that are actually wired up.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100