processing / processing/p5.js-web-editor

Keyboard shortcuts modal is out of sync with actual keybindings

Open
#4,253 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
1.7k
Avg merge
3d 4h
Merged PRs (30d)
8

Description

Follow-up to #4222 (see this comment for context) — KeyboardShortcutModal.jsx has drifted from what's actually wired up in keymaps.js. A few known discrepancies:

Advertised but not implemented:

  • The modal lists {Ctrl/Cmd}+H for "Replace," but there's no replace command wired up anywhere in keymaps.js. Worth deciding: implement it (CodeMirror 6's search panel already supports replace, just needs to be exposed on this shortcut), or remove the claim from the modal if it's not planned.

Implemented but not advertised:

  • Ctrl-Shift-Up/Down (Cmd-Ctrl-Up/Down on Mac) — move line up/down, added in #4250.
  • Shift-Ctrl-D (Shift-Cmd-D on Mac) — duplicate line, and Ctrl-Up/Down (Ctrl-Alt-Up/Down on Mac) — scroll without moving cursor, both pending in a follow-up PR.

Proposal

  1. Decide the fate of the Replace shortcut (implement vs. remove from modal).
  2. Add entries to KeyboardShortcutModal.jsx for the shortcuts above.

Happy to take this on.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing KeyboardShortcutModal.jsx with keymaps.js, then review the context in #4222 and the implementation from #4250. Resolve whether the Replace shortcut should be implemented or removed, and document the listed implemented or pending shortcuts in the modal. Done means the modal matches the keybindings that are actually wired up.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.