processing / processing/p5.js-web-editor

"Add Sketch" option visible to guest users on other users collections

Open Beginner friendly
#4,148 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
JavaScript
Stars
1.7k
Forks
1.7k
Avg merge
3d 4h
Merged PRs (30d)
8

Description

p5.js version

No response

What is your operating system?

Mac OS

Web browser and version

Safari 26.5

Actual Behavior

It is possible to view other users collections via their public URL: https://editor.p5js.org/msawired/collections but as a rule, it is not possible to submit a sketch to collections if user is not the collection owner. However, "Add Sketch" still shows up for guest users. Furthermore, it opens up the sketch list modal and allows user to select a sketch. Ajax call fails with 403 (as expected) but no response is displayed to the user.

Image
Expected Behavior

"Add Sketch" option and modal should not be displayed to guest users until this feature is supported.

Steps to reproduce
Steps:
  1. Login to Editor
  2. View another users collection page such as mine
  3. Click the caret and select "Add Sketch"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on another user's collections page, then trace the collection-page caret and the "Add Sketch" option that opens the sketch list modal. Done means guest users no longer see the option or modal on collections they do not own, while the existing owner flow remains available.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.