primefaces / primefaces/primereact
DataTable: row selection conflicts with cell edit mode
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
On setting the property selectOnEdit to false, I expect the cell edition to not conflicts with the row selection, but currently, when I unselect a row, the cell switch to the edit mode.
Reproducer
https://stackblitz.com/edit/lzu4hr?file=src%2FApp.jsx
PrimeReact version
10.3.1
React version
17.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
- Select a row on clicking on the first cell
- Unselect this row
- The clicked cell switch to the edit mode
Expected behavior
The cell edition should only be enabled on double click and not at the second click in order to not conflicts with the selection/unselection behavior.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked StackBlitz reproducer and compare the DataTable handling of row selection with cell edit mode when selectOnEdit is false. Verify the reported sequence of selecting a row, unselecting it, and clicking the first cell; done means editing begins only on double click, not during the second click used to unselect.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100