primefaces / primefaces/primereact
DataTable: checkIcon prop only applied for rows
Open
Nobody has claimed this yet.
Type: Enhancement
- Dominant language
- CSS
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
The DataTable checkIcon is not applied on the header cell, it's only applied on the rows cell. Please look at the below screenshot
Reproducer
No response
PrimeReact version
9.6.2
React version
17.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
Chrome
Steps to reproduce the behavior
Set the Datable checkIcon prop.
Expected behavior
The checkIcon should also be applied on the header cell for more consistency.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the DataTable in the stated Create React App setup with the checkIcon prop, then compare how the header cell and row cells render their icons. Done means the configured checkIcon is also applied to the header cell consistently with the rows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100