primefaces / primefaces/primereact
DataTable with VirtualScroller: meta key selection bug
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
When DataTable is set with VirtualScroller rows selection is buggy i.e. selecting wide range of rows (that exceeds virtual scroller rendered rows) with shift key selects wrong rows.
Reproducer
https://codesandbox.io/s/primereact-data-table-with-virtual-scroller-selection-errors-forked-ce0w2d
PrimeReact version
9.2.1
React version
18.x
Language
ES6
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked CodeSandbox reproducer and inspect the DataTable selection behavior when VirtualScroller renders only part of the rows. Reproduce a shift-key selection spanning beyond the rendered rows, then verify that the selected range matches the intended rows after the fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100