primefaces / primefaces/primereact
DataTable: filter input not waiting ENTER key to trigger when `showApplyButton={false}`
Open
Nobody has claimed this yet.
Status: Discussion
Type: Enhancement
- Dominant language
- CSS
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
I just updated primereact from 8.1.1 to 8.7.3.
I am working with a DataTable, which filterDisplay is menu and showApplyButton is false. However the filter get triggered when the input changes, it doesn't wait for enter key.
Reproducer
No response
PrimeReact version
8.7.3
React version
18.x
Language
ES6
Build / Runtime
Vite
Browser(s)
Chrome 110
Steps to reproduce the behavior
No response
Expected behavior
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the DataTable filtering entry point and reproduce the menu-filter behavior on PrimeReact 8.7.3 with showApplyButton={false}. Trace how input changes and the ENTER key trigger filtering; done means filtering waits for ENTER when the apply button is hidden.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100