primefaces / primefaces/primereact

Datatable multiple Selection autoFocus to check mark button when it's in edit mode

Open
#2,634 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Status: Pending Review
Dominant language
CSS
Stars
8.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
In Datatable there is a selection with multiple selection mode there was problem earlier that it's auto focus to the checkbox it has been fix in issue #2575, but if i have clicked to edit row clicking any thing in the datatable will auto focus to the check mark button of the edit row.

also trying to fix it with onRowClick for example e.preventDefault, it is work but if the edit input is MultiSelect it does not fix it.
In addition removing the selection fix the problem but the MultiSelect it still auto focus.

Note: i have tried selectionAutoFocus={false} and still same problem

Expected behavior
when it's in the row edit mode and with the selection option enabled, clicking any row or when clicking to MultiSelect or Dropdown item should not auto focus to the check mark button.

Minimal reproduction of the problem with instructions
The example is to add datatable with multiple selection mode and edit row mode when trying to edit click any row or by clicking to MultiSelect or Dropdown item it will auto focus to the check mark button.

Please tell us about your environment:
Windows 10

  • React version:
    17.0.2

  • PrimeReact version:
    7.2.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a DataTable with multiple selection and row edit mode in React 17.0.2 and PrimeReact 7.2.0, then test clicks on the row, MultiSelect, and Dropdown controls. Done means those interactions no longer move focus to the edit-row check mark button, including when selectionAutoFocus is false.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.