primefaces / primefaces/primereact
DataTable dragSelection do not need to be outside the selection range
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
I'm submitting a ... (check one with "x")
[ ] bug report
[ x ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57
Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.
https://codesandbox.io/s/primereact-test-forked-45064
Current behavior
Click select the first row, then drag to select [2,3,4] rows, and the result will be [1, 2, 3, 4] rows
Expected behavior
Only [2, 3, 4] rows need to be selected
Minimal reproduction of the problem with instructions
Please tell us about your environment:
Win11
- React version:
17
- PrimeReact version:
7.0.1
- Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
all
- Language: [all | TypeScript X.X | ES6/7 | ES5]
all
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the DataTable drag-selection case described in the issue, then locate the component's selection handling. Done means dragging from row 1 to rows 2–4 selects only rows 2–4, with coverage for the reported behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100