prettier / prettier/vim-prettier

Running Prettier wipes out all existing marks

Open
#251 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vim Script
Stars
1.8k
Forks
137
PR merge metrics
No merged PRs in 30d

Description

Do you want to request a feature or report a bug?
Report a bug

What is the current/expected behavior?
After running Prettier all user created marks in the current buffer are deleted

What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-alpha

What version of prettier are you using - (output of :PrettierCliVersion) ?
2.0.5

What is your prettier executable path - (output of :PrettierCliPath) ?
Absolute path to the project's node_modules/.bin/prettier

Did this work in previous versions of vim-prettier and/or prettier ?
Haven't tested

So to reproduce:

  1. add a mark via ma
  2. run Prettier (ensure this resulted in some changes)
  3. trying to go to the mark via 'a does not work

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Vim by setting a mark with ma, running Prettier on a buffer that changes, and checking 'a. Start at the implementation behind the Prettier command and its mark handling; done means existing user-created marks remain usable after formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
vim
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.