if with long test, long body and prettier-ignore in else statemet splits test line early
Open
Nobody has claimed this yet.
lang:javascript
- Dominant language
- JavaScript
- Stars
- 52.3k
- Forks
- 5k
- Avg merge
- 19h 2m
- Merged PRs (30d)
- 117
Description
Prettier 2.0.5
Playground link
--parser babel
Input:
if (A_TEST_OF_A_CERTAIN_LENGTH) {
A_CODE_OF_A_SUFFICIENT_LENGTH_______________;
} else
// prettier-ignore
some_call();
Output:
if (
A_TEST_OF_A_CERTAIN_LENGTH
) {
A_CODE_OF_A_SUFFICIENT_LENGTH_______________;
}
// prettier-ignore
else some_call();
Expected behavior:
if (A_TEST_OF_A_CERTAIN_LENGTH) {
A_CODE_OF_A_SUFFICIENT_LENGTH_______________;
}
// prettier-ignore
else some_call();
Notes:
- The bad behavior somehow involves both the length of the test, and the width of the body of the if.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied JSX reproduction in the Prettier Playground using the Babel parser, then trace how the formatter handles the long if condition, body, and prettier-ignore before else. Done means the input retains the condition on one line and matches the expected output without the early split.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100