Ugly positioning for promise then/catch
Open
Nobody has claimed this yet.
area:member chains
lang:javascript
status:needs discussion
- Dominant language
- JavaScript
- Stars
- 52.3k
- Forks
- 5k
- Avg merge
- 19h 2m
- Merged PRs (30d)
- 117
Description
This change makes the code harder to follow.
Input:
dispatch(RequestsDuck.submitRequestComment(id, { text, files }))
.then(() => this.setState({text: '', files: [] }))
then takes up one line and is self contained.
Output:
dispatch(RequestsDuck.submitRequestComment(id, { text, files })).then(() =>
this.setState({ text: '', files: [] })
);
then takes up three lines, starts at the end of another functionality and is overall harder to follow.
Expected behavior:
Expected is that .then starts the new line so that it is more clear and easier to follow the chain, instead of having to look at the end of a line.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Input and Output examples in the issue and trace the formatter logic responsible for promise chains. The change is done when .then begins on a new line for this pattern and the resulting formatting is covered by the relevant formatter tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100