prettier / prettier/prettier

trailingComma setting is not respected in SCSS lists/maps.

Open
#5,736 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

lang:css/scss/less
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

It seems that #4076 has cropped up again?


Prettier 1.15.3
Playground link

--parser scss
--trailing-comma all

Input:

$my-colors: (
  'red',
  'blue',
  'green',
  'pink',
  'orange',
  'purple',
  'magenta',
  'puce',
);

Output:

$my-colors: (
  "red",
  "blue",
  "green",
  "pink",
  "orange",
  "purple",
  "magenta",
  "puce"
);

Expected behavior:

trailingComma setting should be respected:

$my-colors: (
  "red",
  "blue",
  "green",
  "pink",
  "orange",
  "purple",
  "magenta",
  "puce",
);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report in the linked Prettier Playground using the SCSS parser and --trailing-comma all with the provided input. Confirm the formatter preserves the trailing comma in the SCSS list, and add or update a regression test if the relevant test location can be identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, scss
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.