prettier / prettier/prettier

(JSX) period after anchor tag is moved to newline before break

Open
#5,047 10 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:jsx
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier 1.14.2
Playground link

--parser babylon

Input:

const comp = () => (
  <p>
    <a href="https://example.com" style={{ color: "inherit", fontWeight: 600 }}>
      link
    </a>.
    <br />
  </p>
);

Output:

const comp = () => (
  <p>
    <a href="https://example.com" style={{ color: "inherit", fontWeight: 600 }}>
      link
    </a>
    .<br />
  </p>
);

Expected behavior:
For the output to match the input. (. after </a>, not before <br />)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the JSX formatting issue using the linked Prettier Playground with the babylon parser and compare the provided input and output. The work is done when formatting keeps the period after the closing anchor tag and before the br element, matching the expected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.