prettier / prettier/prettier

Extract Prettier’s testing utilities to a separate module

Open
#4,827 11 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:api type:meta
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

I’m helping @mattiaerre get started with a Prettier plugin for Etherum’s Solidity contract language. I realized that Prettier’s run_spec function can be useful in writing tests for plugins, and I copy-pasted them into the codebase, with a few modifications. Should we extract run_spec into a separate module so others can use it and keep it up-to-date? If so, what should we call that module? @prettier/run-spec?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Prettier’s existing run_spec testing utility and reviewing how it is used by the project. Compare it with the copied and modified version in the linked prettier-plugin-solidity pull request; done means deciding whether extraction is appropriate and defining the module’s scope and name.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.