prettier / prettier/prettier

Does not format content inside media query for scss files

Open
#4,523 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:css/scss/less scope:dependency
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier 1.12.1
Playground link

--parser scss

Input:

@media screen and (max-width: calc($tablet     -     100px)) {
      margin: 1em 0;
    }

 @media screen and (max-width: $tablet         -       100px) {
      margin: 1em 0;
    }

Output:

@media screen and (max-width: calc($tablet     -     100px)) {
  margin: 1em 0;
}

@media screen and (max-width: $tablet         -       100px) {
  margin: 1em 0;
}

Expected behavior:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Prettier Playground reproduction using the scss parser and compare formatting of both media-query examples. Trace the SCSS formatting entry point, then add a regression test covering the inputs and verify that whitespace around the expressions and indentation are normalized as shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.