prettier / prettier/prettier

Unnecessary parens around await call

Open
#3,089 15 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:binary expressions lang:javascript status:needs discussion
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier 1.7.4
Playground link

Input:

(async () => {
  foo && await bar();
});

Output:

async () => {
  foo && (await bar());
};

Expected behavior:

Parens around the await call are unnecessary, as evidenced by the fact that it compiles.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Playground example and reproduce the formatting of foo && await bar() using the Babylon parser. Trace the formatter's handling of this expression and verify that the completed change preserves the input without unnecessary parentheses.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.