comment in the middle of return chained call causes unnecessary parentheses
Open
Nobody has claimed this yet.
area:comments
area:member chains
lang:javascript
- Dominant language
- JavaScript
- Stars
- 52.3k
- Forks
- 5k
- Avg merge
- 19h 2m
- Merged PRs (30d)
- 117
Description
return this.http
.get(uri)
.map(theResult => theResult.json())
// foo
.do(foobar => foobar)
.catch(this.handleError);
formats to
return (
this.http
.get(uri)
.map(theResult => theResult.json())
// foo
.do(foobar => foobar)
.catch(this.handleError)
);
I would expect
return this.http
.get(uri)
.map(theResult => theResult.json())
// foo
.do(foobar => foobar)
.catch(this.handleError);
Without the comment,
return this.http
.get(uri)
.map(theResult => theResult.json())
.do(foobar => foobar)
.catch(this.handleError);
formats to
return this.http
.get(uri)
.map(theResult => theResult.json())
.do(foobar => foobar)
.catch(this.handleError);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the TypeScript chained-return example with and without the intervening comment, then trace the formatter behavior for comments in chained calls. Done means the commented chain formats without unnecessary parentheses while the existing no-comment output remains unchanged, with a regression test covering both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100