prettier / prettier/prettier

CSS Modules: Respect print width when composing multiple classes

Open
#2,391 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:css/scss/less
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

This https://github.com/prettier/prettier/pull/2190 is great work, but composes can also accept multiple classes.

For example the following block:

.thumbnailText {
  composes:
    global(c-silver)
    global(lineHeight-s)
    global(breadkPointM-lineHeight-m)
    global(breakPointL-lineHeight-l)
    global(fontSize-xs)
    global(breakPointM-fontSize-s)
    global(breakPointL-fontSize-m);
}

is formatted to:

.thumbnailText {
  composes: global(c-silver) global(lineHeight-s) global(breadkPointM-lineHeight-m) global(breakPointL-lineHeight-l) global(fontSize-xs) global(breakPointM-fontSize-s) global(breakPointL-fontSize-m);
}

(prettier@1.5.2)

It would be nice have one class per line, or respect the print width.

What do you think? I'm happy to create a PR if you'd like 😄

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked Prettier pull request #2190 and the existing CSS formatting behavior for multi-class composes declarations. The work is done when multiple composed classes are broken across lines according to the configured print width, rather than being emitted as one long line.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.