Inconsistent `LogicalExpression` break
Open
Nobody has claimed this yet.
lang:javascript
status:needs discussion
- Dominant language
- JavaScript
- Stars
- 52.3k
- Forks
- 5k
- Avg merge
- 19h 2m
- Merged PRs (30d)
- 117
Description
Prettier PR #19913
Playground link
--parser babel
Input:
async function* f() {
return (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
yield (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
await (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
}
Output:
async function* f() {
return (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
yield (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
await (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc);
}
Expected output:
async function* f() {
return (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
yield (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
await (
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
cccccccccccccccc
);
}
Why?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the case from the linked Playground using the Babel parser and the JSX input in the issue. Compare formatting for the return, yield, and await LogicalExpression examples, then trace the formatter entry point responsible for these expressions. Done means all three forms match the expected output without changing the shown formatting of the return expression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100