prettier / prettier/prettier

Inconsistent `LogicalExpression` break

Open
#20,022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:javascript status:needs discussion
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier PR #19913
Playground link

--parser babel

Input:

async function* f() {
return (
  aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
  bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
  cccccccccccccccc
);

yield (
  aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
);

await (
  aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
);
}

Output:

async function* f() {
  return (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
  );

  yield (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
      bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
      cccccccccccccccc
  );

  await (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc);
}

Expected output:

async function* f() {
  return (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
  );

  yield (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
  );

  await (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&
    cccccccccccccccc
  );
}

Why?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the case from the linked Playground using the Babel parser and the JSX input in the issue. Compare formatting for the return, yield, and await LogicalExpression examples, then trace the formatter entry point responsible for these expressions. Done means all three forms match the expected output without changing the shown formatting of the return expression.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.