prettier / prettier/prettier

Add parentheses for superClass that startsWith object expression

Open
#18,653 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:javascript
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier 3.8.0
Playground link

--parser typescript

Input:

class A extends ({}).Foo {}

Output:

class A extends {}.Foo {}

Second Output:

SyntaxError: Declaration or statement expected. (1:19)
> 1 | class A extends {}.Foo {}
    |                   ^
  2 |

Expected output:

class A extends ({}).Foo {}

Or

class A extends ({}.Foo) {}

Why?

TypeScript can't parse it, even for other parsers that can correctly parse, it still confusing.

This looks like a class property access

class A extends {
  Foo
}.Foo

{}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Prettier Playground input using the TypeScript parser and compare the current output with the expected parenthesized forms. Done means the formatter preserves parentheses around the object expression so the resulting TypeScript remains parseable and unambiguous.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.