prettier / prettier/prettier

Align formatting of `%` with `/` and `*`

Open
#17,597 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lang:javascript lang:typescript
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

This is related to https://github.com/prettier/prettier/issues/187. However, this issue is about one specific operator.

Unfortunately GH search is not very good when searching for symbols, so I couldn't find if there is already a similar issue.

Prettier 3.5.3
Playground link

# Options (if any):

Input:

let high = num % 256 - 128;
let high = num / 256 - 128;

Output:

let high = (num % 256) - 128;
let high = num / 256 - 128;

Expected output:

let high = num % 256 - 128;
let high = num / 256 - 128;

or

let high = (num % 256) - 128;
let high = (num / 256) - 128;

Why?

%, * and / all have the same precedence in JavaScript, so I would expect them to be formatted the same way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Prettier Playground example and compare how % is formatted with / and * at equal JavaScript precedence. Locate the operator-formatting logic and its tests, then add coverage so the output consistently follows one of the expected parenthesization styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.