prettier / prettier/prettier

Comment duplication with experimental ternaries

Open
#15,875 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:comments lang:javascript
Dominant language
JavaScript
Stars
52.3k
Forks
5k
Avg merge
19h 2m
Merged PRs (30d)
117

Description

Prettier 3.1.1
Playground link

--parser babel
--experimental-ternaries

Input:

x = IS_AUTOTEST || (IS_DEV && !IS_TEST)
        ? [
            /*FooBlock*/
          ]
        : []

Output:

x =
  IS_AUTOTEST || (IS_DEV && !IS_TEST) ?
    /*FooBlock*/
    [
      /*FooBlock*/
    ]
  : [];

Expected behavior:

Keep the comment in the output array, don't insert a new one above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Prettier Playground reproduction using the Babel parser and --experimental-ternaries option, then trace how comments are handled when printing this conditional expression. Verify the fix against the supplied JSX input and output, ensuring the existing comment remains only inside the output array.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.