prettier / prettier/plugin-php

tab formation and inline

Open
#926 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion inline ugly
Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

Prettier 1.14.3

PHP Plugin 0.9.0

# Options (if any):
--single-quote

Input:

function wp_admin_bar_header()
{
	?>
<style type="text/css" media="print">#wpadminbar { display:none; }</style>
	<?php
}

Output:

function wp_admin_bar_header()
{
    ?>
<style type="text/css" media="print">#wpadminbar { display:none; }</style>
	<?php
}

Expected behavior:

function wp_admin_bar_header()
{
    ?>
<style type="text/css" media="print">#wpadminbar { display:none; }</style>
    <?php
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the issue with the provided PHP input and compare the formatter's handling of the PHP-to-inline-HTML boundaries; done means the closing and reopening PHP tags use the expected four-space indentation without changing the inline style block.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.