prettier / prettier/plugin-php
ugly comments in `offsetlookup`
Open
Nobody has claimed this yet.
comments
ugly
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Description
Prettier 1.14.3
PHP Plugin 0.9.0
# Options (if any):
--single-quote
Input:
$var = $var
// Comment
['foo'] // Comment
// Comment
['bar'] // Comment
// Comment
['baz'] // Comment
// Comment
['qqq'];
Output:
$var = // Comment // Comment // Comment
// Comment
// Comment
// Comment
// Comment
$var['foo']['bar']['baz']['qqq'];
Expected behavior:
$var =
$var[
// Comment
"foo"
][ // Comment
// Comment
"bar"
][ // Comment
// Comment
"baz"
][ // Comment
// Comment
"qqq"
];
As prettier
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported PHP input with the Prettier PHP plugin and inspect the offsetlookup handling named in the issue. Compare the formatter output with the expected output, and consider the work complete when comments remain attached to the corresponding array offsets without being collapsed into the assignment line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100