prettier / prettier/plugin-php

respect comment between `try`, `catch` and `finally`

Open
#829 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

comments ugly
Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

Prettier 1.14.3

PHP Plugin 0.9.0

Same as for if, else if and else

Input:

// Comment
try {
    return tap($callback($this), function () {
        $this->commit();
    });
}
// Comment
catch (FooException $e) {
    throw $e;
}
// Comment
catch (BarException $e) {
    throw $e;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Reproduce the supplied PHP input with the formatter and trace the handling of comments around try, catch, and finally clauses. Done means comments between these clauses are preserved in the formatted output.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.