prettier / prettier/plugin-php
Wrapping of static method calls
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Description
The plugin is currently wrapping variable static method calls before the double-colon ::. This seems wrong to me, but at least warrants some further discussion. It doesn't appear to be mentioned in PER-CS 2.0 at all, so it's not technically wrong. We do not do this wrapping direct static method calls from a class name, only from a variable.
@prettier/plugin-php v0.22.4
Playground link
Input:
<?php
$thisIsAReallyLongVariableNameUsedToTriggerTheBehaviour::staticMethod()
->anotherMethod();
Output:
<?php
$thisIsAReallyLongVariableNameUsedToTriggerTheBehaviour
::staticMethod()
->anotherMethod();
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Playground reproduction and inspect the formatter path responsible for line breaking around static method calls. Reproduce the variable static call case, compare it with direct class-name calls, and consider the issue done when the intended wrapping behavior is established and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100