prettier / prettier/plugin-php

Bug with mixture of php with comments and html

Open
#2,419 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

Prettier 3.5.3

PHP Plugin 0.22.4

# Options (if any):

Input:

<?php
const a = true;
?><div></div>
<?php if (2==2) {
  // comment
  ?><span></span><?php
  return true;
}

Output:

<?php
const a = true; ?><div></div>
<?php if (2 == 2) {<?php
    // comment
    ?><span></span><?php return true;}

Expected behavior:
< ? php above the comment line at the end is not needed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Reproduce the provided mixed PHP/HTML example with Prettier 3.5.3 and PHP Plugin 0.22.4, then trace the formatter behavior around the comment and PHP opening tag. Done means the unnecessary opening tag is absent and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.