prettier / prettier/plugin-php

Parentheses incorrectly removed from functions defined and called on the same line

Open
#2,409 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

This code, which recursively computes the 10th Fibonacci number:

$result = ($fib = function($n) use (&$fib) {
    return $n <= 1 ? $n : $fib($n - 1) + $fib($n - 2);
})(10);

is incorrectly simplified to this:

$result = $fib = function ($n) use (&$fib) {
    return $n <= 1 ? $n : $fib($n - 1) + $fib($n - 2);
}(10);

removing the parentheses leads to incorrect code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported PHP example with the formatter and compare its output with the expected parenthesized form. Trace the PHP printer logic responsible for formatting an assignment containing an immediately invoked function, then add a regression test demonstrating that the parentheses remain when the function is defined and called on the same line.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.