prettier / prettier/plugin-php
First class callable syntax treated like arguments, trailing comma causes error
Open
Nobody has claimed this yet.
bug
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Description
@prettier/plugin-php v0.19.3
Playground link
Input:
<?php
return $this->longMethodName(
$this->longPropertyName->evenLongerMethodNameNowCausesTheDotsToWrapWithComma(...),
);
Output:
<?php
return $this->longMethodName(
$this->longPropertyName->evenLongerMethodNameNowCausesTheDotsToWrapWithComma(
...,
),
);
Expected Output:
No trailing comma after ... in first class callable syntax, which is a syntax error. Or preferentially treating the (...) as being inseparable and not allowing line breaks inside it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the provided input in the linked playground and comparing the current output with the expected output. Trace the PHP formatter path for first-class callable syntax and ensure the finished formatting has no comma after ..., or keeps the callable parentheses unbroken.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100