prettier / prettier/plugin-php

Ugly: Wrong indent in empty array with //comment inside

Open
#1,864 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

@prettier/plugin-php v0.17.6
Playground link

Input:

<?php

return [
  // TODO: ...
];

return [
  // TODO: ...
  'foo' => 'bar',
];

return [
  'foo' => 'bar',
];

Output:

<?php

return [
        // TODO: ...
    ];

return [
    // TODO: ...
    "foo" => "bar",
];

return [
    "foo" => "bar",
];

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Playground reproduction using the provided PHP input and compare the formatter output with the expected indentation. Trace the formatter behavior for arrays containing only a comment, then verify that the empty-array case matches the shown output without changing the other examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.