prettier / prettier/plugin-php

Comment of last argument gets replaced

Open
#1,745 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug comments
Dominant language
PHP
Stars
1.9k
Forks
139
PR merge metrics
No merged PRs in 30d

Description

The comment of the last argument gets replaced. This also applies to /* block comments */.

@prettier/plugin-php v0.16.3
Playground link

Input:

<?php

class MyClass {
  public static function from(
    int $value1, // comment works
    int $value2 // comment gets moved down
    ) {
    
  }
}
    


Output:

<?php

class MyClass
{
    public static function from(
        int $value1, // comment works
        int $value2
    ) {
        // comment gets moved down
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the formatter output for the linked playground example using @prettier/plugin-php v0.16.3, including the line and block comment cases. Trace how the last argument's comment is handled and verify that it remains attached to that argument rather than moving into the function body.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.