prettier / prettier/plugin-php
Invalid output caused by "inline" node before "leadingComments" node
Open
Nobody has claimed this yet.
bug
comments
inline
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Description
@prettier/plugin-php v0.11.2
Playground link
Input:
with space before the PHP starting tag
<?php // comment
echo the_content(); ?>
Output:
<?php // comment
// comment
?>echo the_content(); ?>
The extra PHP closing tag break the PHP code itself
Note: In case I remove the space before the PHP starting tag, the output is correct:
Input:
<?php // comment
echo the_content(); ?>
Output:
<?php // comment
echo the_content(); ?>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Playground example and reproduce the formatter output using the input with a leading space before the PHP tag. Trace the handling of the inline and leading comment nodes; done means formatting no longer inserts a duplicate comment or PHP closing tag and preserves the valid PHP code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100